Open
Conversation
Owner
patrick-kidger
left a comment
patrick-kidger
left a comment
There was a problem hiding this comment.
It looks like the autoformatter isn't happy -- can you take a look at CONTRIBUTING.md?
Other than this, this looks great to me, I think it solves both issues perfectly. Thank you for taking the time to tackle this!
Author
|
Thank you for the comment! I agree, using jnp.full is a better way. I fixed this and followed the instructions in CONTRIBUTING.md. |
Owner
|
Hmm, this is a little odd -- we seem to be seeing a flake in an unrelated test. Your changes themselves seem fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed both bugs 323 and 324 and tested linear, rectilinear and cubic interpolations with both empty and random matrices. Tests are passing but I am getting 4 warnings (which I assume are not related to the changes since they're related to some deprecation.